-
Notifications
You must be signed in to change notification settings - Fork 83
feat(job-orchestration): Allow concurrent compression job processing by processing batches of compression tasks per job. #1637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+402
−158
Merged
Changes from 23 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
c7cf648
feat(job-orchestration): Improve scheduling fairness by batching comp…
junhaoliao 9b9e360
fix lint
junhaoliao 31ab2a4
fix all G004 in VCS changed lines
junhaoliao b8c2936
fix all TRY401 in VCS changed lines
junhaoliao 0cb7fae
fix all F841 in VCS changed lines
junhaoliao 76423df
refactor into helpers and add docs
junhaoliao cd6930e
refactor search_and_schedule_new_tasks and poll_running_jobs for clar…
junhaoliao 6fb54f2
refactor compression job handling to use DbContext for database opera…
junhaoliao 50361f9
refactor compression job handling to improve task batching and metada…
junhaoliao 2413d53
fix all DTZ005
junhaoliao a80c829
lint
junhaoliao a46b0ea
line after desc
junhaoliao ac310a6
add docstring to DbContext
junhaoliao 672e81b
fix docstring for job scheduling function
junhaoliao 4fe7076
refactor parameter order in batch and dispatch functions
junhaoliao e8847ee
enhance compression scheduler with additional comments and remove unu…
junhaoliao e1b14f5
remove redundant comment in task dispatch logic
junhaoliao 4f764df
reorder
junhaoliao bcc5e75
add comment to clarify task submission process in compression scheduler
junhaoliao 261b206
restore main entry point in compression scheduler
junhaoliao f8aa1d1
rename `num_tasks_per_sub_job` to `max_concurrent_tasks_per_job`
junhaoliao 7e6ac2c
Allow unlimited concurrent tasks per job
junhaoliao 2acde6d
Merge branch 'main' into batch-compression-tasks
junhaoliao 8b0b5d2
Merge branch 'main' into batch-compression-tasks
junhaoliao 0a2735e
update task running status for current batch only; Extract task statu…
junhaoliao 9da4ea1
revert changes in query_scheduler.py
junhaoliao 5196cf0
lint
junhaoliao d639446
Specify type hints for `job_id` and `kv` in compression scheduler fun…
junhaoliao 1df8f05
Merge branch 'main' into batch-compression-tasks
junhaoliao dc28f53
Refactor SQL queries in `compression_scheduler.py` to use parameteriz…
junhaoliao f8acfe2
add comment about setting 0 to disable the task scheduling limit per …
junhaoliao 78df192
Fix spacing in `clp_config.py` comment for `max_concurrent_tasks_per_…
junhaoliao 8b456ae
Merge branch 'main' into batch-compression-tasks
junhaoliao 1065b1e
docs - Apply suggestions from code review
junhaoliao 24edafc
refactor(clp_config): Use a constant for unlimited concurrent tasks p…
junhaoliao 9282174
Merge branch 'main' into batch-compression-tasks
junhaoliao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.