-
Notifications
You must be signed in to change notification settings - Fork 83
feat(package)!: Add Spider compression orchestration in docker compose package. #1606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sitaowang1998
wants to merge
486
commits into
y-scope:main
Choose a base branch
from
sitaowang1998:spider-job-integration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 250 commits
Commits
Show all changes
486 commits
Select commit
Hold shift + click to select a range
e58512a
docs(quick-start): Add required containerd, Docker CE, CLI, and compo…
junhaoliao d3b34cf
Revert "Fix enum"
sitaowang1998 cc9a1f4
refactor(config): Rename type `Host` -> `DomainStr`; Add TODO docstri…
junhaoliao 96ac165
Merge branch 'main' into pydantic-impf
junhaoliao 04929ea
Add custom annotation for serialization
sitaowang1998 57b2789
Remove field without custom serialization
sitaowang1998 0b6f43c
Bug fix
sitaowang1998 d7b40b0
Merge branch 'main' into docker-compose
junhaoliao 06d9c39
Add custom annotation for serialization
sitaowang1998 43c2295
Remove field without custom serialization
sitaowang1998 e09d497
Bug fix
sitaowang1998 8e0f163
Fix lint
sitaowang1998 37a0a8a
restore verbose logging option to start_clp script.
junhaoliao 4878bd2
Fix merge
sitaowang1998 cc71ad1
Fix orchestration type
sitaowang1998 c608e7b
Bug fix
sitaowang1998 358fe4b
Fix compression scheduler
sitaowang1998 535b696
Add spider table creation
sitaowang1998 a405aea
Fix none tag id
sitaowang1998 7d18129
fix(docker): Move USER and ENV directives after image flattening in c…
junhaoliao ef046e5
fix(docker): Include `libmariadbcpp.so` (required by `spider_schedule…
junhaoliao cfa71d8
Make COPY arch-agnostic and include SONAME symlinks
junhaoliao b193c2f
Merge branch 'main' into fix-clp-package-docker
junhaoliao f83a4b6
Merge branch 'main' into bundle-mariadb
junhaoliao 3195ef0
feat(docker): Update clp-package Dockerfile; add non-root user and se…
junhaoliao 18a1b18
fix(docker): Reorder and restructure ENV directives in clp-package Do…
junhaoliao 3ef8714
add \
junhaoliao 5a4826f
Merge branch 'main' into spider-job-integration
sitaowang1998 37b4eda
Merge branch 'docker-compose' into spider-job-integration
sitaowang1998 3a57db7
Merge branch 'main' into pydantic-enum
sitaowang1998 e487f82
Fix enum
sitaowang1998 1b2d4cb
Merge branch 'main' into fix-clp-package-docker
junhaoliao 3cdf245
Merge remote-tracking branch 'origin/main' into docker-compose
junhaoliao 95d900a
refactor(clp-py-utils): Use DEFAULT_PORT for WebUi port configuration.
junhaoliao f6cbc7f
apply docs suggestions
junhaoliao 5bf0887
refactor(controller): Rename clp_config -> _clp_config for consistent…
junhaoliao 26dfaca
refactor(deployment): Rename Redis environment variables for improved…
junhaoliao 99e983f
Apply suggestions - Reformat multiline statements and remove unnecess…
junhaoliao 0b028dc
Apply suggestions - Rename UID/GID environment variables for improved…
junhaoliao f11963c
Apply suggestions - Use constants for jobs table names.
junhaoliao c98ba25
Merge branch 'bundle-mariadb' into spider-job-integration
sitaowang1998 50dc075
Add spider docker files and the use of them
sitaowang1998 f55e96c
Merge branch 'pydantic-enum' into spider-job-integration
sitaowang1998 d993b2e
Merge branch 'docker-compose' into spider-job-integration
sitaowang1998 2fc6a72
Bug fix
sitaowang1998 3a6dcd8
Fix private var
sitaowang1998 8253a1d
Update docker files
sitaowang1998 b7b4b7c
Fix docker
sitaowang1998 ad95784
Fix storage url
sitaowang1998 d79b58e
Fix docker file
sitaowang1998 91cb9fc
refactor(controller): Remove redundant `stderr` redirection from subp…
junhaoliao 1d57a89
docs: move high-level comments to individual blocks
junhaoliao f4254fa
docs(controller): reference issue for revisiting worker count logic
junhaoliao 932c334
refactor(controller): add `--wait` flag to `docker compose up` comman…
junhaoliao a8cee64
refactor(controller): replace `Dict` with a custom `EnvVarsDict` for …
junhaoliao f0e1740
lint
junhaoliao 6679c2d
use local variable in assignment in _update_settings_object()
junhaoliao 416c31a
refactor(controller): remove redundant try-except blocks around `subp…
junhaoliao 9ab85d2
add warning log for failed Docker dependency check before attempting …
junhaoliao 1345de3
refactor(controller): add explicit return type annotations for all me…
junhaoliao 25c3812
Merge branch 'main' into docker-compose
junhaoliao 3c3e23d
refactor(scripts): move `instance_id` assignment inside `try` block i…
junhaoliao 7c43aad
revert `--config` argument removal in `stop_clp` to allow specifying …
junhaoliao 63c700a
refactor(config): Rename CLP_DEFAULT_ARCHIVE_* -> CLP_DEFAULT_ARCHIVE…
junhaoliao 0f7c78c
apply docs suggestions
junhaoliao 5e07756
docs(clp-package-utils): Update docstrings for clarity and consistency.
junhaoliao ff4f06c
remove return type from dump_shared_container_config()
junhaoliao e381c3d
refactor(clp-package-utils): Rename base_config -> component_config i…
junhaoliao f426c82
Simplify raised error message for missing configuration file: redis
junhaoliao 73ec68f
Apply suggestion - To alphabetize
junhaoliao 4e707ae
Remove individual log file paths and use shared logging volume
junhaoliao 6f53877
fix(controller): revert removal of "ClpQueryEngine" in server_setting…
junhaoliao e7addd3
refactor(clp-package-utils): Rename CLP_PACKAGE_CONTAINER -> CLP_PACK…
junhaoliao d4e81f3
fix(docker-compose): use `:?error` syntax to mark required non-empty …
junhaoliao a5a497d
disallow empty `username` and `password` in `Database` because our db…
junhaoliao 0dd11ce
fix(docker-compose): Update default database image to mariadb:10-jammy.
junhaoliao d27a0b1
fix(docker-compose): Add stop_grace_period for compression-worker and…
junhaoliao a6478e6
apply docs suggestions
junhaoliao 7bbd134
refactor(docker-compose): Rename volume_root_logs_readonly -> volume_…
junhaoliao 04e56f0
ensure `healthcheck` goes after `command`
junhaoliao 0fc91d7
fix(docker-compose): Add AWS credentials environment variables in web…
junhaoliao f307d94
fix(docker-compose): Update environment variables for archive and str…
junhaoliao e5a90dd
Replace "docker-compose" (usually refer to v1) with "Docker Compose" …
junhaoliao 3015ec4
lint
junhaoliao ff43c78
refactor(clp-package-utils): Reorder functions and rename is_docker_c…
junhaoliao 699979a
fix(docker-compose): Add mounts for archive and stream output in garb…
junhaoliao 092a86c
refactor(clp-package-utils): Rename _is_docker_compose_running -> _is…
junhaoliao 8d75171
fix(docker-compose): Rename CLP_AWS_ACCESS_KEY_ID -> CLP_STREAM_OUTPU…
junhaoliao f53339f
fix(docker-compose): Break long volume mount lines for improved reada…
junhaoliao 18d1109
lint
junhaoliao 84c011b
Add main for script
sitaowang1998 272706f
Bandit solution for column width
sitaowang1998 234f0f0
Fix docker compose
sitaowang1998 9d9bd46
refactor(clp-package-utils): Rename should_compose_run -> should_comp…
junhaoliao 225c6c5
Merge branch 'main' into docker-compose
junhaoliao 24db721
Merge branch 'main' into bundle-mariadb
junhaoliao 127aacc
refactor(clp-package-utils): Reorder private functions
junhaoliao f5ea3e2
Replace EnvironmentError with OSError as per Ruff os-error-alias (UP024)
junhaoliao 22593d8
refactor(general): Improve error handling for Docker and Docker Compose
junhaoliao bc69b26
refactor(general): Update dump_container_config call to remove return…
junhaoliao 1d2ab61
refactor(docs): Update exception documentation to use 'raise' format
junhaoliao d4c921a
add missing `f` in f-string
junhaoliao 31b6618
Merge branch 'docker-compose' into spider-job-integration
sitaowang1998 5bac1ff
Merge branch 'main' into spider-job-integration
sitaowang1998 e6bb002
Add retention periods check for garbage collector and disable the ser…
junhaoliao 90ee7da
Merge branch 'main' into docker-compose
junhaoliao 61b57b7
Merge branch 'docker-compose' into spider-job-integration
sitaowang1998 134e959
Fix merge
sitaowang1998 45b119e
Fix lint
sitaowang1998 8a8400f
Fix single return type
sitaowang1998 029b641
Merge branch 'spider-one-task' into spider-job-integration
sitaowang1998 50037cc
Merge docker file
sitaowang1998 079ff48
Fix LD_LIBRARY_PATH
sitaowang1998 2c08c94
Bug fix
sitaowang1998 812bb25
Use empty tag ids instead of None
sitaowang1998 46fcb98
Merge branch 'tag-id-none' into spider-job-integration
sitaowang1998 7ef1c94
Revert None support for tag_ids
sitaowang1998 6913123
Merge branch 'spider-one-task' into spider-job-integration
sitaowang1998 e210cea
Fix yaml lint
sitaowang1998 b19b1ec
Merge remote-tracking branch 'origin/main' into bundle-mariadb
junhaoliao 78a7af3
Merge branch 'main' into fix-clp-package-docker
junhaoliao b3e673f
fix(docker): Use `--link` flag in COPY command for clp-package Docker…
junhaoliao 65f2d1b
fix(docker): Reorder COPY command in clp-package Dockerfile
junhaoliao b522212
fix(docker): Add ARG for UID and set ownership in COPY command for cl…
junhaoliao 42fba6c
merge with the latest from #1413
junhaoliao 99d353a
Merge branch 'main' into bundle-mariadb
sitaowang1998 dba99b7
Merge branch 'main' into fix-clp-package-docker
junhaoliao 8580b7a
Merge branch 'main' into bundle-mariadb
junhaoliao 360cac6
Merge branch 'main' into fix-clp-package-docker
junhaoliao b0d0bcc
refactor(clp-package-utils): Remove unused `pass` statements from abs…
junhaoliao 955a0ac
refactor(clp-config): Remove unused typing import 'Set'.
junhaoliao 106fdda
apply doc suggestions
junhaoliao 7a1ea6e
refactor(docker-compose): Update environment variable error messages …
junhaoliao a732939
Adjust volume bindings to fix directory mappings when CLP_STAGED_ARCH…
junhaoliao c687f78
fix string indents
junhaoliao 19e8a9d
apply doc suggestions
junhaoliao c53c0f1
apply doc suggestions
junhaoliao a2fa02c
fix(clp-package-utils): Remove extra space in `.env` file comment.
junhaoliao 05810be
apply doc suggestions
junhaoliao 2a02ecb
apply doc suggestions
junhaoliao 678de80
Update comment for `_get_num_workers` method - apply doc suggestion
junhaoliao c30adae
Simplify log message for CLP start action - apply suggestion
junhaoliao 07d1e35
Update comments for consistency in `controller.py`.
junhaoliao 0bf6b70
feat(clp-package-utils): Add custom exceptions for Docker dependency …
junhaoliao 913dea3
Merge branch 'main' into fix-clp-package-docker
junhaoliao 2986082
fix(clp-package-utils): Use `docker --version` to check docker availa…
junhaoliao e499443
Avoid mapping ~/.aws on host when CLP_AWS_CONFIG_DIR_HOST is undefined
junhaoliao b788c33
alphabetize mounts
junhaoliao 6fc219c
Do not map logs input dir when CLP_LOGS_INPUT_DIR_HOST is undefined
junhaoliao 0926180
lint
junhaoliao e2daf32
lint
junhaoliao 736c805
Merge remote-tracking branch 'origin/main' into docker-compose
junhaoliao 4956106
fix: Add AWS config directory mount to garbage collector
junhaoliao 91cacb0
fix(clp-package-utils): Add return type annotations to custom excepti…
junhaoliao 3ad7f70
Merge branch 'main' into docker-compose
junhaoliao 8a991cc
Merge branch 'main' into fix-clp-package-docker
junhaoliao 3a99370
Merge branch 'docker-compose' into spider-job-integration
sitaowang1998 a6598e6
Adapt spider docker file
sitaowang1998 89f0a1c
Merge branch 'main' into fix-clp-package-docker
sitaowang1998 2be2d5c
Fix docker file
sitaowang1998 dda9534
Merge branch 'fix-clp-package-docker' into spider-job-integration
sitaowang1998 36b0f9a
Fix docker file log env
sitaowang1998 8a7549a
Merge branch 'bundle-mariadb' into spider-job-integration
sitaowang1998 6901432
Merge branch 'main' into spider-job-integration
sitaowang1998 fb8c8e0
Parse spider related config selectively
sitaowang1998 cd2b8c2
Remove unused doc before merge main
sitaowang1998 a17b9b2
Update spider docker file
sitaowang1998 2888b63
Fix docker file
sitaowang1998 16a8f29
Fix merge
sitaowang1998 4879aa1
Fix spider docker merge
sitaowang1998 3a80b30
Merge branch 'main' of github.com:y-scope/clp into spider-job-integra…
sitaowang1998 bc901fc
Merge branch 'main' into spider-job-integration
sitaowang1998 fca9019
Merge branch 'main' into spider-job-integration
sitaowang1998 a587187
Fix merge
sitaowang1998 c9fbb46
Merge branch 'main' into spider-job-integration
sitaowang1998 551c309
Use bytes
sitaowang1998 ac660b2
Update spider library
sitaowang1998 9909731
Bump spider-py version
sitaowang1998 ed3ebb8
Merge branch 'main' into spider-job-integration
sitaowang1998 37e9639
Update mariadb version
sitaowang1998 2f75a06
Fix merge
sitaowang1998 999f834
Update lock file
sitaowang1998 375636b
Fix lint
sitaowang1998 ecf685d
Remove docker package in doc
sitaowang1998 dc808fd
Remove used function
sitaowang1998 b34acf3
Fix docstring
sitaowang1998 2e820be
Fix valdiator
sitaowang1998 9bf4c34
Fix clp config spider db check
sitaowang1998 e054086
Fix exception catching
sitaowang1998 75412d7
Remove name validation
sitaowang1998 75cab42
Add error checking for start spider worker script
sitaowang1998 d618074
Fix fstring
sitaowang1998 616dd47
Fix clp config
sitaowang1998 4845e92
Fix lint
sitaowang1998 e7cb62f
Apply suggestions from code review
sitaowang1998 bebb2e9
Fix logger name
sitaowang1998 5b3b0cf
Fix deleted row
sitaowang1998 c0db520
Use different credential for spider-db
sitaowang1998 e2a6889
Print error when password is not available
sitaowang1998 9ff80fa
Rename variable for clarity
sitaowang1998 2bc5a4f
Check for redis and queue
sitaowang1998 4ce8b53
Add check for redis and queue
sitaowang1998 4aab3f1
Add transform for container for spider scheduler
sitaowang1998 fbfd166
Add domain name
sitaowang1998 36c2a1e
Use enum
sitaowang1998 cc89521
Fix error message
sitaowang1998 a4d069f
Fix error message
sitaowang1998 62c338c
Apply suggestions from code review
sitaowang1998 77a8743
Merge branch 'spider-job-integration' of github.com:sitaowang1998/clp…
sitaowang1998 e786e75
Check concurrency argument
sitaowang1998 6312bfb
Use logger instead of print
sitaowang1998 99f1662
Remove unnecessary fix
sitaowang1998 ee6e5a4
Skip creating spider table if not configured
sitaowang1998 f1781ac
Use internal network address
sitaowang1998 7afe76e
Merge branch 'main' into spider-job-integration
sitaowang1998 0b652d7
Remove override
sitaowang1998 46a031b
Fix username
sitaowang1998 bf72451
Fix spider db password
sitaowang1998 0e9c1bb
Bug fix
sitaowang1998 3c08754
Pass user and password using env
sitaowang1998 8eb7e23
Fix env
sitaowang1998 d22b423
Fix error path return
sitaowang1998 07e44a5
Fix yml name
sitaowang1998 7379b61
lint
sitaowang1998 9f82f96
Fix
sitaowang1998 0502111
Fix lint
sitaowang1998 93a5af2
Merge branch 'main' into spider-job-integration
sitaowang1998 a52a266
Use relative path for sibling
sitaowang1998 b7668e3
Add spider config in config template
sitaowang1998 ae8a6ae
Add spider db in credential template
sitaowang1998 a2c449d
Fix script
sitaowang1998 92a9744
Use same volume
sitaowang1998 84f016d
Add missing template
sitaowang1998 2293d50
Construct spider db url in docker
sitaowang1998 e072dcb
Merge branch 'main' into spider-job-integration
sitaowang1998 60ef08b
Move get ip into start worker script
sitaowang1998 dcc834a
Bug fix
sitaowang1998 74a3149
Add back optional host, improve error handling
sitaowang1998 9177d4e
Merge branch 'main' into spider-job-integration
sitaowang1998 01c60a2
Apply suggestions from code review
sitaowang1998 3c502d2
Apply suggestion from code review
sitaowang1998 3d0c8ed
Rename argument
sitaowang1998 c312c19
Fix name
sitaowang1998 7b5f9ef
Merge branch 'main' into spider-job-integration
sitaowang1998 4a0e776
Bug fix
sitaowang1998 c20f321
Fix spider db credential
sitaowang1998 bd9a78d
Fix mariadb type hint
sitaowang1998 515a3d3
Fix db password
sitaowang1998 6a56869
Merge branch 'main' into spider-job-integration
sitaowang1998 5135fe8
Bug fix
sitaowang1998 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.