WIP - feat(deployment): Add k8s Helm chart for CLP package deployment. #1603
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| ports: | ||
| - port: 3306 | ||
| targetPort: 3306 | ||
| --- |
There was a problem hiding this comment.
fine to allow --- in helm yamls?
| app.kubernetes.io/component: "database" | ||
| ports: | ||
| - port: 3306 | ||
| nodePort: 30306 |
There was a problem hiding this comment.
shall we expose the port using NodePort, or ask users to run kubectl port-forward to expose ports explicitly for databases?
| ports: | ||
| - port: 4000 | ||
| targetPort: 4000 | ||
| nodePort: 30400 |
There was a problem hiding this comment.
shall we set up nginx ingress instead of this?
| @@ -0,0 +1,17 @@ | |||
| apiVersion: "v2" | |||
| name: "clp-package" | |||
There was a problem hiding this comment.
- is this name fine?
- is the
tools/deployment/package-helmname fine?
| apiVersion: "v1" | ||
| kind: "ConfigMap" | ||
| metadata: | ||
| name: {{ include "clp-package.fullname" . }}-config |
There was a problem hiding this comment.
maybe -generated-config?
|
|
||
| storage: | ||
| # Base directory on host when using local PVs. | ||
| localPathBase: "/tmp/clp" |
There was a problem hiding this comment.
maybe just a clpHome key at the root? or we enforce users to specify absolute paths in the clpConfig
There was a problem hiding this comment.
i believe it's better to enforce absolute paths in clpConfig, so that we don't have to do path manipulations with go templates. though that means users can't just directly copy over an already working clp-config.yml and paste into clpConfig - they will have to adjust all paths to use absolute paths
junhaoliao
changed the title
…ix query scheduler hostname binding issue.
…r, queue, and redis.
| port: 6379 | ||
| query_backend_database: {{ .Values.clpConfig.redis.query_backend_database }} | ||
| reducer: | ||
| base_port: {{ .Values.clpConfig.reducer.base_port }} |
There was a problem hiding this comment.
technically we can hardcode this since we dont need to expose the ports outside of the cluster?
Co-authored-by: kirkrodrigues <[email protected]>
# Conflicts: # tools/deployment/package-helm/templates/configmap.yaml # tools/deployment/package-helm/templates/database-statefulset.yaml # tools/deployment/package-helm/test.sh # tools/deployment/package-helm/values.yaml
…goDB) as `StatefulSet` into the CLP Package Helm chart.
# Conflicts: # tools/deployment/package-helm/templates/_helpers.tpl # tools/deployment/package-helm/templates/configmap.yaml # tools/deployment/package-helm/test.sh # tools/deployment/package-helm/values.yaml
2 participants
this PR is meant to be reference only and should not be merged.
Description
Checklist
breaking change.
Validation performed