XWIKI-23335: The upload widget throws an error after uploading an attachment #4324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tachment * Updated the attachments.js to check for existence of the element before using it
Farcasut
changed the title
oanalavinia
reviewed
Jun 26, 2025
Contributor
oanalavinia
left a comment
oanalavinia
left a comment
There was a problem hiding this comment.
Looks good!
Did you also run the AttachmentIT tests?
Contributor
Author
Yes, here is a screenshot: |
oanalavinia
approved these changes
Jun 26, 2025
Contributor
oanalavinia
left a comment
oanalavinia
left a comment
There was a problem hiding this comment.
Thanks! :)
I'll merge this next week after the 17.5.0 release, to not affect the CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-23335
Changes
Description
Updated the attachments.js to check for existence of the element before using it.
Expected merging strategy