Skip to content

Conversation

@coderaiser
Copy link
Contributor

Looks like pid on windows is wrong. There is such issue in pty.js repo maybe it is still not fixed in node-pty. Anyway changing the way of killing process works for me.

> [email protected] start C:\Users\coderaiser\Documents\GitHub\xterm.js
> node demo/app

App listening to http://127.0.0.1:3000
Created terminal with PID: 928
Connected to terminal 928
internal/process.js:173
      throw errnoException(err, 'kill');
      ^

Error: kill ESRCH
    at exports._errnoException (util.js:1022:11)
    at process.kill (internal/process.js:173:13)
    at WebSocket.<anonymous> (C:\Users\coderaiser\Documents\GitHub\xterm.js\demo\app.js:72:13)
    at emitTwo (events.js:111:20)
    at WebSocket.emit (events.js:191:7)
    at WebSocket.cleanupWebsocketResources (C:\Users\coderaiser\Documents\GitHub\xterm.js\node_modules\ws\lib\WebSocket.js:950:8)
    at emitOne (events.js:101:20)
    at Socket.emit (events.js:188:7)
    at emitErrorNT (net.js:1281:8)
    at _combinedTickCallback (internal/process/next_tick.js:74:11)

npm ERR! Windows_NT 10.0.14393
npm ERR! argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "start"
npm ERR! node v7.2.0
npm ERR! npm  v3.10.9
npm ERR! code ELIFECYCLE
npm ERR! [email protected] start: `node demo/app`
npm ERR! Exit status 1

@coveralls
Copy link

Coverage Status

Coverage remained the same at 67.786% when pulling 43558fa on coderaiser:patch-1 into 8693d06 on sourcelair:master.

@Tyriar
Copy link
Member

Tyriar commented Mar 3, 2017

Makes sense, this part of the code wasn't changed when I adopted node-pty. Thanks for looking into this @coderaiser 😃

@Tyriar Tyriar merged commit c9ad3a5 into xtermjs:master Mar 3, 2017
@Tyriar Tyriar added this to the 2.4.0 milestone Mar 3, 2017
@coderaiser coderaiser deleted the patch-1 branch March 27, 2017 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants