Fixes #562 adds Windows demo setup help #569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
It looks like the tests failed, but all I changed was the README, so I assume I didn't cause that? |
Tyriar
requested changes
Feb 25, 2017
README.md
Outdated
| npm install | ||
| npm start | ||
| > npm install | ||
| > npm install node-pty |
Member
There was a problem hiding this comment.
You shouldn't need to do this as it's done in npm install
Contributor
Author
|
Oh, I see, I think that was just because my build stuff wasn't set up right, and that was the only module I needed to reinstall. Removing. |
Tyriar
approved these changes
Feb 27, 2017
Member
|
The test failure is related to TypeScript 2.2, I made a commit to fix the issue. Thanks @wavebeem 😄 |
Contributor
Author
|
Thanks for your help and the sweet project! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.