Make fit plugin guard against non-existent parent element. #544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
reviewed
Feb 13, 2017
src/addons/fit/fit.js
Outdated
|
|
||
| exports.proposeGeometry = function (term) { | ||
| if (!term.element.parentElement) { | ||
| return false; |
Member
There was a problem hiding this comment.
I think null would be more fitting here, other than that looks good
Contributor
Author
There was a problem hiding this comment.
Sure thing, I'll update the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the terminal's parent element is removed from the DOM and the
.fit()method is called, an error is thrown.This PR introduces guard logic that checks if the parent exists.