Add null checks in eraseRight and eraseLeft #520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parisk
approved these changes
Feb 1, 2017
Contributor
parisk
left a comment
parisk
left a comment
There was a problem hiding this comment.
LGTM 👍
Can we pinpoint the issue thought that might call eraseRight with invalid x and y? This way we can fix the root of evil.
Member
Author
|
It was running some script that was piping data between xterm.js and a remote server, I think it was happening due to either interleaved CSI codes or the delay between server and host. I'll keep an eye out. |
Member
Author
|
Looks like the remote process was running with different dimensions to the xterm.js instance which likely caused this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #519