Skip to content

Conversation

@Tyriar
Copy link
Member

@Tyriar Tyriar commented Jan 21, 2017

This PR adds British, Dutch, Finnish, French, French Canadian, German, Italian, Norwegian/Danish, Spanish, Swedish and Swiss character sets. They can be turn on using echo -e '\x1b(A' where A is the language code, this example will turn on the UK character set, changing any # to £.

@Tyriar Tyriar self-assigned this Jan 21, 2017
@Tyriar Tyriar requested a review from parisk January 21, 2017 04:18
@parisk
Copy link
Contributor

parisk commented Jan 21, 2017

Great, maybe we can create an example page in xtermjs/xtermjs-org to document how a consumer app can change the charset.

@parisk
Copy link
Contributor

parisk commented Jan 21, 2017

Should we also expose a public API for setting charset?

@Tyriar
Copy link
Member Author

Tyriar commented Jan 21, 2017

I don't think so, this seems like more of a legacy thing since changing keyboars layouts works just fine without this. This just allows programs to output certain Unicode characters without actually using Unicode if they desire.

@Tyriar Tyriar merged commit ca19da1 into xtermjs:master Jan 25, 2017
@Tyriar Tyriar deleted the 481_character_sets branch January 25, 2017 21:00
@Tyriar Tyriar added this to the 2.3.0 milestone Jan 25, 2017
@Tyriar Tyriar modified the milestone: 2.3.0 Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants