Skip to content

Only keep > 0 geometry in CharMeasure #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Tyriar merged 1 commit into from
Jan 20, 2017
Merged

Only keep > 0 geometry in CharMeasure #495

Tyriar merged 1 commit into from
Jan 20, 2017

Conversation

@Tyriar
Copy link
Member

@Tyriar Tyriar commented Jan 20, 2017

Fixes #494

@Tyriar Tyriar added this to the 2.3.0 milestone Jan 20, 2017
@Tyriar Tyriar self-assigned this Jan 20, 2017
@Tyriar Tyriar requested a review from parisk January 20, 2017 02:03
Tyriar added a commit to xtermjs/xtermjs.org that referenced this pull request Jan 20, 2017
@Tyriar
Explain emitting scroll event manually
8b201df 
Related to xtermjs/xterm.js#494 and xtermjs/xterm.js#495
@Tyriar Tyriar mentioned this pull request Jan 20, 2017
Merged
@Tyriar
Copy link
Member Author

Tyriar commented Jan 20, 2017

This fixes the major issue of the viewport size completely breaking, there is one remaining issue though. When you show the element after the resize, if the resize was smaller then the scroll bar will still be out of sync. This requires a manual term.emit('scroll') which is fine. I created xtermjs/xtermjs.org#12 to document this.

@Tyriar Tyriar merged commit 1c759f1 into xtermjs:master Jan 20, 2017
@Tyriar Tyriar deleted the 494_display_none_resize_fix branch January 20, 2017 15:26
@Tyriar Tyriar modified the milestone: 2.3.0 Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@parisk parisk parisk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Tyriar Tyriar

Labels

None yet

Projects

None yet

Milestone

2.3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Tyriar @parisk