Skip to content

Don't drop selection on modifier keyup #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Tyriar merged 1 commit into from
Jan 16, 2017
Merged

Don't drop selection on modifier keyup #482

Tyriar merged 1 commit into from
Jan 16, 2017

Conversation

@Tyriar
Copy link
Member

@Tyriar Tyriar commented Jan 16, 2017

Fixes #348

@Tyriar Tyriar added this to the 2.3.0 milestone Jan 16, 2017
@Tyriar Tyriar self-assigned this Jan 16, 2017
@Tyriar Tyriar requested a review from parisk January 16, 2017 05:42
parisk
parisk approved these changes Jan 16, 2017
View reviewed changes
Copy link
Contributor

@parisk parisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.

@Tyriar Tyriar merged commit 259338b into xtermjs:master Jan 16, 2017
@Tyriar Tyriar modified the milestone: 2.3.0 Feb 2, 2017
@Tyriar Tyriar deleted the 348_keep_selection_on_mod_key branch February 3, 2017 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@parisk parisk parisk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Tyriar Tyriar

Labels

None yet

Projects

None yet

Milestone

2.3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Tyriar @parisk