Skip to content

Add disableStdin option #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Tyriar merged 1 commit into from
Jan 9, 2017
Merged

Add disableStdin option #453

Tyriar merged 1 commit into from
Jan 9, 2017

Conversation

@Tyriar
Copy link
Member

@Tyriar Tyriar commented Jan 4, 2017

Fixes #452

Testing done:

  1. Launch demo
  2. In dev tools term.setOption('disableStdin', true);
  3. Check input doesn't work but scrolling does
  4. In dev tools term.setOption('disableStdin', false);
  5. Check everything works

@Tyriar Tyriar added this to the 2.3.0 milestone Jan 4, 2017
@Tyriar Tyriar self-assigned this Jan 4, 2017
@Tyriar Tyriar requested a review from parisk January 4, 2017 20:44
@Tyriar Tyriar mentioned this pull request Jan 4, 2017
Closed
@parisk
Copy link
Contributor

parisk commented Jan 8, 2017

Isn't this something that can be easily implemented by the consumer app, by using the attachCustomKeydownHandler method?

@Tyriar
Copy link
Member Author

Tyriar commented Jan 9, 2017

Mouse input is also stdin, check references to Terminal.send.

@parisk
Copy link
Contributor

parisk commented Jan 9, 2017

That's right 👍

parisk
parisk approved these changes Jan 9, 2017
View reviewed changes
Copy link
Contributor

@parisk parisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tyriar Tyriar merged commit 27a7f15 into xtermjs:master Jan 9, 2017
@Tyriar Tyriar deleted the 452_disable_stdin_option branch January 9, 2017 17:53
@Tyriar Tyriar modified the milestone: 2.3.0 Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@parisk parisk parisk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Tyriar Tyriar

Labels

None yet

Projects

None yet

Milestone

2.3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Tyriar @parisk