Use node-pty for Windows support #442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
changed the title
Member
Author
|
This is blocked on the gulp build #435 |
Member
Author
|
@parisk ready for review |
Member
Author
|
Just tested again after rebase, works on Windows! |
PerBothner
added a commit
to PerBothner/DomTerm
that referenced
this pull request
Feb 28, 2023
This is to work around the FitAddon measuring the parent element of the xterm element - see xtermjs/xterm.js#442
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #441
This combined with #435 Windows dev should work. This is the fork used in Hyper and VS Code, I will publish a named release soon, see the README.