Skip to content

Fix a11y issues #4269 #4284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 16, 2022
Merged

Fix a11y issues #4269 #4284

merged 1 commit into from
Dec 16, 2022

Conversation

@JasonXJ
Copy link

@JasonXJ JasonXJ commented Dec 2, 2022

No description provided.

@JasonXJ JasonXJ mentioned this pull request Dec 2, 2022
Closed
@JasonXJ
Copy link
Author

JasonXJ commented Dec 13, 2022

Hi @Tyriar , can you take a look at this new version?

Tyriar
Tyriar approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, seems reasonable 👍

@Tyriar Tyriar merged commit 0b56255 into xtermjs:master Dec 16, 2022
@Tyriar Tyriar added this to the 5.1.0 milestone Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

5.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@JasonXJ @Tyriar