Clean up npm publish #419
Merged
Clean up npm publish #419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@blink1073 thanks for putting the effort on this, but is not the intended behavior. The issue is that this would break applications that depend on either the built monolith or the TypeScript sources and install xterm via npm. To make it work in such a case it would require a build step before using it, which is not desired. Let me know if I understood well and it is OK to close this. Otherwise, please share the reasons you would like to remove these files from the NPM package (e.g. are they introducing issues in your application that depends on xterm.js?). |
Contributor
Author
|
The intent of this PR was to make sure the CSS file was getting published, removing the other paths was in response to #416 (comment). Updating now. |
Contributor
|
Thanks a lot @blink1073! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure the full build script is run before publishing, ensuring that CSS files are copied, for example.