Always build TypeScript in lib/
#407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
You will want to remove any generated test files in lib/, we don't want them in the npm package. Do glob patterns work in package.json |
Contributor
Tyriar
reviewed
Dec 13, 2016
| .lock-wscript | ||
| out/ | ||
| lib/*.test.js | ||
| lib/*.test.js.map |
: 
parisk
force-pushed
the
build-ts-into-lib
branch
from
1b604f3 to
230d277
Compare
parisk
force-pushed
the
build-ts-into-lib
branch
from
230d277 to
e23956c
Compare
Tyriar
approved these changes
Dec 13, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we publish
libto npm after #398, I do not think that there is any reason to keep theoutdirectory.Also this will make it easier for people that clone the bare repo to work (or else they will have to run the "prepublish" script).