Improve the package.json scripts #402
Conversation
|
Overall, this is a great addition 👍 , just two comments:
|
| /.idea/ | ||
| .env | ||
| build/ | ||
| .vscode/ |
There was a problem hiding this comment.
Curious what you're ignoring here, did an extension or something change some workspace settings?
There was a problem hiding this comment.
I'm using VS code scripts while developing, which are saved in .vscode, so since Xterm.js is used in VS code, I felt that's Ok to keep this here 😇
I can definitely remove this if you believe it's not needed.
There was a problem hiding this comment.
Let's leave this here, since vscode might be creating any files, I think it's a good idea to ignore them for sure.
Non-blocking question: Should we change this to /.vscode/ like the /.idea/ above or not?
There was a problem hiding this comment.
@akalipetis thanks, I was mainly just wondering if an extension was being naughty 😛
.vscode can only appear at the root of the repo so .vscode/ should be fine.
akalipetis
force-pushed
the
hotfix-npm-scripts
branch
from
dd95afa to
c048131
Compare
parisk
left a comment
parisk
left a comment
There was a problem hiding this comment.
LGTM 🚀 .
It just needs to resolve the conflict in package.json before merging 🙂 .
1. Include a `prestart` script, which runs the build 2. Make the `start` script just start the demo server 3. Add a new `dev` script, which contains the nodemon logic 4. nodemon now watches for changes in `*.ts` files and runs the start command Signed-off-by: Antonis Kalipetis <[email protected]>
Also, update the Procfile.dev with the updated `npm run dev` command. Signed-off-by: Antonis Kalipetis <[email protected]>
akalipetis
force-pushed
the
hotfix-npm-scripts
branch
from
c048131 to
f00ea4b
Compare
3 participants
prestartscript, which runs the buildstartscript just start the demo serverdevscript, which contains the nodemon logic*.tsfiles and runs the start commandThis allows for easier development, while also makes the different scripts we use simpler and self-contained.