Skip to content

Allow markers on the alt buffer #3924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 31, 2022
Merged

Allow markers on the alt buffer #3924

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
89f5c2e
Allow markers on the alt buffer
silamon Jul 24, 2022
2fffe9f
Merge branch 'master' into allowmarkersonaltbuffer
Tyriar Jul 28, 2022
0e07e41
Merge branch 'master' into allowmarkersonaltbuffer
Tyriar Jul 28, 2022
848acea
Merge branch 'master' into allowmarkersonaltbuffer
Tyriar Jul 28, 2022
0a83040
clearAllMarkers
silamon Jul 31, 2022
14d5999
Update src/common/buffer/BufferSet.test.ts
Tyriar Jul 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/browser/Terminal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -956,11 +956,6 @@ export class Terminal extends CoreTerminal implements ITerminal {
}

public addMarker(cursorYOffset: number): IMarker | undefined {
// Disallow markers on the alt buffer
if (this.buffer !== this.buffers.normal) {
return;
}

return this.buffer.addMarker(this.buffer.ybase + this.buffer.y + cursorYOffset);
}

Expand Down