Skip to content

update search results onBufferContentsChange #3811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 17, 2022
Merged

update search results onBufferContentsChange #3811

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6895215
if cached line is empty, translate buffer line to string
meganrogge May 14, 2022
820dad3
onRenderedBufferChange => onRenderedViewportChange
meganrogge May 16, 2022
1db5323
add onBufferContentsChange
meganrogge May 16, 2022
0b0d0d8
remove check for empty string
meganrogge May 16, 2022
f8c9acd
Merge branch 'master' into fix-cache
Tyriar May 16, 2022
6b573b9
Update src/common/CoreTerminal.ts
meganrogge May 16, 2022
564ea1a
Update typings/xterm.d.ts
meganrogge May 16, 2022
25e1d59
Fix compile
Tyriar May 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion addons/xterm-addon-search/src/SearchAddon.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,7 +498,10 @@ export class SearchAddon implements ITerminalAddon {
return this._findInLine(term, searchPosition, searchOptions);
}
let cache = this._linesCache?.[row];
if (!cache) {
if (!cache || cache[0] === '') {
// sometimes the search refresh happens before the
// buffer has content for a given line, so if the cached
// line is empty, check it again to avoid issues like #3794
cache = this._translateBufferLineToStringWithWrap(row, true);
if (this._linesCache) {
this._linesCache[row] = cache;
Expand Down