add overview ruler #3676
Merged
add overview ruler #3676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganrogge
commented
Mar 9, 2022
meganrogge
commented
Mar 9, 2022
Tyriar
requested changes
Mar 11, 2022
Member
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
One theme I've noticed that I think we should move away from is the idea of buffer decorations vs scroll bar decorations. Instead there are decorations, all decorations are rendered in the buffer and some get rendered in the scroll bar. I think the latter is how it works but most of the code is structured in the other direction.
Co-authored-by: Daniel Imms <[email protected]>
…eganrogge/xterm.js into merogge/scroll-bar-decorations
Co-authored-by: Daniel Imms <[email protected]>
Co-authored-by: Daniel Imms <[email protected]>
Co-authored-by: Daniel Imms <[email protected]>
Co-authored-by: Daniel Imms <[email protected]>
…eganrogge/xterm.js into merogge/scroll-bar-decorations
Co-authored-by: Daniel Imms <[email protected]>
Co-authored-by: Daniel Imms <[email protected]>
…eganrogge/xterm.js into merogge/scroll-bar-decorations
Co-authored-by: Daniel Imms <[email protected]>
Co-authored-by: Daniel Imms <[email protected]>
Co-authored-by: Daniel Imms <[email protected]>
Co-authored-by: Daniel Imms <[email protected]>
Co-authored-by: Daniel Imms <[email protected]>
…eganrogge/xterm.js into merogge/scroll-bar-decorations
Tyriar
approved these changes
Mar 16, 2022
This was referenced Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3632