Skip to content

Conversation

@Tyriar
Copy link
Member

@Tyriar Tyriar commented Nov 21, 2016

Fixes #363


Notes:

  • This is the first TypeScript file
  • I'm suggesting a new format for .ts test files so they lay right next to the source file they're testing, this prevents duplicating the directory structure under the test/ dir
  • The new @types dependencies provide type information for mocha and chai, allowing TypeScript to check the types when compiling. From TS 2 this is as easy as running npm i -D @types/mocha

@parisk
Copy link
Contributor

parisk commented Nov 22, 2016

I am totally 👍 for the new test file format. Sounds much more sane.

@Tyriar Tyriar merged commit dcbf014 into xtermjs:master Nov 22, 2016
@Tyriar Tyriar deleted the 363_modifier_keys_no_scroll branch November 22, 2016 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants