dispose of markers on buffer clear #3628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
requested changes
Feb 4, 2022
Member
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
Looks like there's a test related change needed to implement an interface
Tyriar
approved these changes
Feb 4, 2022
Member
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
Looks good, an API test that creates 2 markers, scrolls them into scrollback, then creates 2 more and makes sure they get disposed on clear would be great too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #1852, I noticed that when
clearis called, the decorations aren't disposed of because their markers aren't disposed.