Skip to content

Point to correct assets after TS build #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tyriar merged 2 commits into from
Nov 16, 2016
Merged

Point to correct assets after TS build #353

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99496de
Point to correct assets after TS build
Tyriar Nov 12, 2016
e6f21f0
Make all dist/ references in index.html absolute
Tyriar Nov 14, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion demo/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ var pty = require('pty.js');
var terminals = {},
logs = {};

app.use('/build', express.static(__dirname + '/../build'));
app.use('/dist', express.static(__dirname + '/../dist'));

app.get('/', function(req, res){
res.sendFile(__dirname + '/index.html');
Expand Down
12 changes: 6 additions & 6 deletions demo/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@
<html>
<head>
<title>xterm.js demo</title>
<link rel="stylesheet" href="../build/xterm.css" />
<link rel="stylesheet" href="../build/addons/fullscreen/fullscreen.css" />
<link rel="stylesheet" href="../dist/xterm.css" />
Copy link
Contributor

@parisk parisk Nov 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use absolute URLs here as well?

Copy link
Member Author

@Tyriar Tyriar Nov 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good eye 😄

<link rel="stylesheet" href="../dist/addons/fullscreen/fullscreen.css" />
<link rel="stylesheet" href="style.css" />
<script src="https://cdnjs.cloudflare.com/ajax/libs/fetch/1.0.0/fetch.min.js"></script>
<script src="/build/xterm.js" ></script>
<script src="/build/addons/attach/attach.js" ></script>
<script src="/build/addons/fit/fit.js" ></script>
<script src="/build/addons/fullscreen/fullscreen.js" ></script>
<script src="/dist/xterm.js" ></script>
<script src="/dist/addons/attach/attach.js" ></script>
<script src="/dist/addons/fit/fit.js" ></script>
<script src="/dist/addons/fullscreen/fullscreen.js" ></script>
</head>
<body>
<h1>xterm.js: xterm, in the browser</h1>
Expand Down