Skip to content

Fix the textarea in the composition view's pos when composing #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Tyriar merged 1 commit into from
Oct 24, 2016
Merged

Fix the textarea in the composition view's pos when composing #323

Tyriar merged 1 commit into from
Oct 24, 2016

Conversation

@Tyriar
Copy link
Member

@Tyriar Tyriar commented Oct 24, 2016

Fixes #322

parisk
parisk approved these changes Oct 24, 2016
View reviewed changes
Copy link
Contributor

@parisk parisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍰

@Tyriar Tyriar merged commit 269540b into xtermjs:master Oct 24, 2016
@Tyriar Tyriar deleted the 322_ime_bad_position branch October 24, 2016 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@parisk parisk parisk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Tyriar @parisk