Skip to content

Issue #313 document terminal constructor #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
parisk merged 3 commits into from
Oct 24, 2016
Merged

Issue #313 document terminal constructor #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
605d61b
Ignore `.env` files that set the environment
parisk Oct 23, 2016
a9417c6
Fix `term.geometry` and document it in constructor options
parisk Oct 23, 2016
e8e7870
Remove `geometry` option from terminal consttructor
parisk Oct 23, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,4 @@ example/*.log
docs/
npm-debug.log
/.idea/
.env
6 changes: 5 additions & 1 deletion src/xterm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,9 @@ var normal = 0, escaped = 1, csi = 2, osc = 3, charset = 4, dcs = 5, ignore = 6;
* Creates a new `Terminal` object.
*
* @param {object} options An object containing a set of options, the available options are:
* - cursorBlink (boolean): Whether the terminal cursor blinks
* - `cursorBlink` (boolean): Whether the terminal cursor blinks
* - `cols` (number): The number of columns of the terminal (horizontal size)
* - `rows` (number): The number of rows of the terminal (vertical size)
*
* @public
* @class Xterm Xterm
Expand Down Expand Up @@ -125,6 +127,7 @@ function Terminal(options) {

this.cols = options.cols || options.geometry[0];
this.rows = options.rows || options.geometry[1];
this.geometry = [this.cols, this.rows];

if (options.handler) {
this.on('data', options.handler);
Expand Down Expand Up @@ -2942,6 +2945,7 @@ Terminal.prototype.resize = function(x, y) {

this.normal = null;

this.geometry = [this.cols, this.rows];
this.emit('resize', {terminal: this, cols: x, rows: y});
};

Expand Down