Skip to content

Fix getSelection not working sometimes for single character selections #2973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Tyriar merged 1 commit into from
Jun 11, 2020
Merged

Fix getSelection not working sometimes for single character selections #2973

Tyriar merged 1 commit into from
Jun 11, 2020

Conversation

@daniel-j-davis
Copy link

@daniel-j-davis daniel-j-davis commented Jun 11, 2020

… #2617

@Tyriar Tyriar added this to the 4.7.0 milestone Jun 11, 2020
@Tyriar Tyriar self-assigned this Jun 11, 2020
Tyriar
Tyriar approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch for looking into this 😃

@Tyriar Tyriar changed the title onSelectionChange() not getting called for single character selection… Fix getSelection not working sometimes for single character selections Jun 11, 2020
@Tyriar Tyriar merged commit f928c7e into xtermjs:master Jun 11, 2020
@Tyriar Tyriar linked an issue Jun 11, 2020 that may be closed by this pull request
getSelection() does not return a single character selection #2617
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@Tyriar Tyriar

Labels

None yet

Projects

None yet

Milestone

4.7.0

Development

Successfully merging this pull request may close these issues.

getSelection() does not return a single character selection

2 participants

@daniel-j-davis @Tyriar