non-transparent selection covers text

[Puneethnaik]

#2737 issue fix. @Tyriar Please look into this. Would love to hear feedback.

[Puneethnaik]

@Tyriar Please consider the changes. I observed some checks had failed.(Particularly the integration tests). I have committed few changes that passes all the checks. I moved logic from ColorManager setTheme function to a function in color namespace in Color.ts. Also, I invoke the function in DomRenderer and Renderer class constructor. Would love to hear feedback.

[Tyriar]

@Puneethnaik I'll check this out next week, after a quick look at the code it looks pretty much like what I had in mind 👍

[Puneethnaik]

@Tyriar thanks for considering the PR. Since this is my first PR in xterm.js, I am very excited. Will wait for the review and any feedback 👍. Meanwhile I will keep studying the codebase, learnt a lot.

[Tyriar]

@Puneethnaik good to hear 🙂, there's always more help wanted issues if you're keen.

[Puneethnaik]

@Tyriar Thank you for the feedback. I fixed the code while consulting the feedback and pushed a commit. However, the checks are not passing. Upon some investigation, it seems a 404 Not found error occured, When I looked at the Azure devops log. I checked under linux tests section. There the message contained url: 'https://github.com/tonsky/FiraCode/raw/master/distr/otf/FiraCode-Regular.otf',
Upon following the link, it gave a 404. I checked the recent commit of FiraCode on the master branch(link here it seems that FiraCode-Regular.otf is removed in this commit.
Please guide me on this.

[Tyriar]

The font CI problem should get fixed with #2971

[Tyriar]

Thanks for the help with this @Puneethnaik! 🚀

[Puneethnaik]

Thank you @Tyriar. It is really an honor to start my open source track record by contributing to a great product like xterm.js. I will keep looking at more issues and try to contribute more.