Skip to content

fixed ScreenDprListener never being fired #2892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tyriar merged 2 commits into from
May 2, 2020
Merged

fixed ScreenDprListener never being fired #2892

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40a09d7
fixed ScreenDprListener never being fired
Eugeny May 2, 2020
930de9a
Update src/browser/ScreenDprMonitor.ts
Eugeny May 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/browser/ScreenDprMonitor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,14 @@ export class ScreenDprMonitor extends Disposable {
}

private _updateDpr(): void {
if (!this._resolutionMediaMatchList || !this._outerListener) {
if (!this._outerListener) {
return;
}

// Clear listeners for old DPR
this._resolutionMediaMatchList.removeListener(this._outerListener);
if (this._resolutionMediaMatchList) {
this._resolutionMediaMatchList.removeListener(this._outerListener);
}

// Add listeners for new DPR
this._currentDevicePixelRatio = window.devicePixelRatio;
Expand Down