Different behavior when search two same words in only one row #2867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Search must wrap back as it does when there are multiple lines.
RishabhKothaari
changed the title
RishabhKothaari
changed the title
Tyriar
requested changes
Apr 25, 2020
Member
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
Seems to work well, it should also work for find previous as well
Contributor
Author
|
@Tyriar do you mean if we hit the beginning(column 0) with find previous we must wrap again to the end of the column or last search selection? |
wrap back search selection to last selected result when we hit top
handle wrap back with find previous
Contributor
Author
|
Let me know if any other changes are required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2840. We must wrap back search to 0th column if we have a
currentSelection. @Tyriar let me know if any further changes are required.