Skip to content

Conversation

@JavaCS3
Copy link
Contributor

@JavaCS3 JavaCS3 commented Feb 12, 2020

See #2694

@JavaCS3 JavaCS3 requested review from Tyriar and mofux February 12, 2020 04:49
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking we're completely replace buffer, making buffer a namespace and moving the actual IBuffer object lower:

class Terminal {
  readonly buffer: IBufferNamespace;
}

interface IBufferNamespace {
  readonly normal: IBuffer;
  readonly alternate: IBuffer;
  readonly active: IBuffer;
  // Change as that's the word used in other APIs
  onBufferChange: IEvent<IBuffer>;
}

interface IBuffer {
  type: 'normal' | 'alternate';
}

This would need changes in addons but buffer is experimental so that's fine.

@JavaCS3
Copy link
Contributor Author

JavaCS3 commented Feb 12, 2020

@Tyriar But there're a lot of test cases using buffer API.
image
I would suggest adding a new buffers API and deprecate the old API, that will make the transition smoother

@Tyriar
Copy link
Member

Tyriar commented Feb 12, 2020

@JavaCS3 it's primarily just internal things though, most of those would probably get fixed by doing a project-wide find and replaces, for example "term.buffer.x" -> "term.buffers.active.x"

@JavaCS3 JavaCS3 requested a review from Tyriar February 13, 2020 04:22
@JavaCS3
Copy link
Contributor Author

JavaCS3 commented Mar 6, 2020

@Tyriar Updated

@JavaCS3
Copy link
Contributor Author

JavaCS3 commented Apr 5, 2020

@Tyriar Updated, Looks like there're a lot of pending PRs. Does xterm.js have any schedule to clean them up?

@Tyriar
Copy link
Member

Tyriar commented Apr 10, 2020

@JavaCS3 I've been a bit busy with other things in VS Code, this week has been catching up on this stuff and hopefully getting a release out.

@Tyriar Tyriar added this to the 4.5.0 milestone Apr 10, 2020
@Tyriar Tyriar self-assigned this Apr 10, 2020
@Tyriar Tyriar merged commit a66edbd into xtermjs:master Apr 10, 2020
MatthewZMD added a commit to emacs-eaf/emacs-application-framework that referenced this pull request Jan 20, 2021
Introduced by xtermjs/xterm.js#2713

Run `npm install` at EAF root directory if an error occurs due to this commit.

Signed-off-by: Mingde (Matthew) Zeng <[email protected]>
MatthewZMD added a commit to emacs-eaf/eaf-terminal that referenced this pull request Aug 11, 2021
Introduced by xtermjs/xterm.js#2713

Run `npm install` at EAF root directory if an error occurs due to this commit.

Signed-off-by: Mingde (Matthew) Zeng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants