-
Notifications
You must be signed in to change notification settings - Fork 1.8k
expose IBufferSet API #2713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expose IBufferSet API #2713
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking we're completely replace buffer, making buffer a namespace and moving the actual IBuffer object lower:
class Terminal {
readonly buffer: IBufferNamespace;
}
interface IBufferNamespace {
readonly normal: IBuffer;
readonly alternate: IBuffer;
readonly active: IBuffer;
// Change as that's the word used in other APIs
onBufferChange: IEvent<IBuffer>;
}
interface IBuffer {
type: 'normal' | 'alternate';
}This would need changes in addons but buffer is experimental so that's fine.
|
@Tyriar But there're a lot of test cases using |
|
@JavaCS3 it's primarily just internal things though, most of those would probably get fixed by doing a project-wide find and replaces, for example "term.buffer.x" -> "term.buffers.active.x" |
|
@Tyriar Updated |
|
@Tyriar Updated, Looks like there're a lot of pending PRs. Does xterm.js have any schedule to clean them up? |
|
@JavaCS3 I've been a bit busy with other things in VS Code, this week has been catching up on this stuff and hopefully getting a release out. |
Introduced by xtermjs/xterm.js#2713 Run `npm install` at EAF root directory if an error occurs due to this commit. Signed-off-by: Mingde (Matthew) Zeng <[email protected]>
Introduced by xtermjs/xterm.js#2713 Run `npm install` at EAF root directory if an error occurs due to this commit. Signed-off-by: Mingde (Matthew) Zeng <[email protected]>

See #2694