Fix Link Provider end positions

[jmbockhorst]

Fixes #2708.

[Tyriar]

Is it possible for a test to cover this? Maybe a unit test (.test.ts) that verifies onLinkHover/onLinkLeave events have the right coordinates?

[jmbockhorst]

I'm not sure how to simulate the mouse events needed to fire the onLinkHover/onLinkLeave events from the test file.

From my understanding as LinkifierEvent is used here:

xterm.js/src/browser/renderer/LinkRenderLayer.ts

Line 68 in 1bb2fc9

this._fillBottomLineAtCells(e.x1, e.y1, e.x2 - e.x1);

A link from col: 5 - 7 (1 based) should create a link event where x: 4 - 7 (0-based).

[Tyriar]

Yeah that's a bit tricky... Well an easy, slightly hacky way to do it would be to:

• Make _linkHover protected
• Extend Linkifier2 with a TestLinkifier2
• Expose TestLinkifier2.linkHover that calls into _linkHover

Then make a test that passes in some any objects, while not good because of the any, the bad type shouldn't matter so much as the tests will fail if when something goes wrong (or when something is refactored):

it('...', done => {
  linkifier.onLinkHover(e => {
    // assert on e based on the link used
    done();
  });
  linkifier.linkHover({ classList: { add: () => {} } } as any, { /*fill in link*/ }, {} as any);
});

[jmbockhorst]

Thanks, that works.