Skip to content

Fix focus on mouseup when mousedown was in another element #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Tyriar merged 1 commit into from
Sep 16, 2016
Merged

Fix focus on mouseup when mousedown was in another element #268

Tyriar merged 1 commit into from
Sep 16, 2016

Conversation

@Tyriar
Copy link
Member

@Tyriar Tyriar commented Sep 15, 2016

Fixes #267

parisk
parisk approved these changes Sep 16, 2016
View reviewed changes
Copy link
Contributor

@parisk parisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 .

Works great.

@Tyriar Tyriar merged commit b89bce1 into xtermjs:master Sep 16, 2016
@Tyriar Tyriar deleted the 267_fix_mouseup_focus branch September 16, 2016 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@parisk parisk parisk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Tyriar @parisk