-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Fixes Alt + click behaviour when rows are wrapped #2670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Tyriar Some MoveToCell tests are failing. Should they be updated or, my implementation is wrong? |
|
@kumaran-14 well this test was enforcing the old behavior which you've now broken: You'll need to update the test to respect the new behavior. Make sure there's a test for moving across a single line and multiple lines as well. |
|
@Tyriar can you look into this? |
|
@kumaran-14 I'll probably free up next week to power through xterm.js stuff and release 4.4 |
|
@Tyriar Sure. That sounds awesome. I'd like to finish this and contribute more. |
Tyriar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It only seems to wrap around 1 row currently, so if the prompt spans multiple rows you need multiple clicks to get it where you want it.
|
Another thing I noticed is that the current algorithm doesn't look at whether the row is wrapped, it should only move along the current wrapped row. I'm looking into fixing these issues now so we can get this merged in. |
|
@Tyriar How do I get the positions of buffer end? |
Tyriar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @kumaran-14, I made a couple of changes including adding some more complete tests so we can merge this in.
|
@Tyriar Sure. Glad to help. |


Fixes #2658.