Skip to content

fix: Renderer: IntersectionObserver can produce more then 1 entry #1929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 4, 2019
Merged

fix: Renderer: IntersectionObserver can produce more then 1 entry #1929

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
69d3a46
fix: Renderer: IntersectionObserver can produce more then 1 entry
coderaiser Feb 4, 2019
b0f01be
Merge branch 'master' into patch-1
coderaiser Feb 15, 2019
05b162e
Merge branch 'master' into patch-1
Tyriar Mar 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/renderer/Renderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export class Renderer extends EventEmitter implements IRenderer {
// Detect whether IntersectionObserver is detected and enable renderer pause
// and resume based on terminal visibility if so
if ('IntersectionObserver' in window) {
const observer = new IntersectionObserver(e => this.onIntersectionChange(e[0]), { threshold: 0 });
const observer = new IntersectionObserver(e => this.onIntersectionChange(e[e.length - 1]), { threshold: 0 });
observer.observe(this._terminal.element);
this.register({ dispose: () => observer.disconnect() });
}
Expand Down