Prevent charsizechanged from firing unnecessarily

[juancampa]

Problem

charsizechanged was being fired regardless of whether the actual char size changed or not.

Solution

Only fire the event when the "adjusted size" (rounded up) changes.

I ran into this bug because, when using the WebGL renderer, canvas resizes are very expensive on Chrome. This was causing the renderer to resize the canvas every time measure was called.

Tests

• Terminal resizes up/down when changing the number of cols/rows
• Terminal resizes up/down when changing the font size

[juancampa]

@Tyriar let me know if there's other functionality you'd like me to test. So far it seems like nothing breaks

[Tyriar]

@juancampa you mentioned changing this caused some other bug, was that something in your local workspace?

[juancampa]

Yes. It worked fine in a clean working tree

…

On Wed, Jan 16, 2019, 2:53 PM Daniel Imms ***@***.*** wrote: @juancampa <https://github.com/juancampa> you mentioned changing this caused some other bug, was that something in your local workspace? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1897 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABWF2E2j3UrhRAanl7JGI5_dD6B3PVuHks5vD4NWgaJpZM4aBR4g> .