Skip to content

Don't print keys that print more than a single char #1881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2019
Merged

Don't print keys that print more than a single char #1881

merged 1 commit into from
Jan 7, 2019

Conversation

@Tyriar
Copy link
Member

@Tyriar Tyriar commented Jan 4, 2019

Fixes #1880

@Tyriar Tyriar added this to the 3.11.0 milestone Jan 4, 2019
@Tyriar Tyriar self-assigned this Jan 4, 2019
@Tyriar Tyriar mentioned this pull request Jan 4, 2019
Closed
@pfitzseb
Copy link
Contributor

pfitzseb commented Jan 4, 2019

Yeah, this is definitely better than my attempt at a fix.
Would it be possible to get this into a 3.10.1? I'd really like to use 3.10 because of the improved search API, but this issue is a blocker.

@Tyriar
Copy link
Member Author

Tyriar commented Jan 4, 2019

Yeah I think we'll need to do a 3.10.1 for this based on the amount of issues I've seen come into the vscode report, we'll probably release it on the 8th.

@Tyriar Tyriar modified the milestones: 3.11.0, 3.10.1 Jan 4, 2019
jerch
jerch approved these changes Jan 4, 2019
View reviewed changes
Copy link
Member

@jerch jerch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues from my side, tested with possible key combinations i have (2nd and 3rd) with Firefox and Chrome.

@Tyriar Tyriar mentioned this pull request Jan 7, 2019
Closed
3 tasks
@Tyriar Tyriar merged commit 509ce5f into xtermjs:master Jan 7, 2019
@Tyriar Tyriar deleted the 1880_key_repeat branch January 7, 2019 23:11
juancampa added a commit to juancampa/hyper that referenced this pull request Jan 14, 2019
@juancampa
Fix modifier keys being printed (xtermjs/xterm.js/pull/1881)
497898c
@juancampa juancampa mentioned this pull request Jan 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jerch jerch jerch approved these changes

Assignees

@Tyriar Tyriar

Labels

None yet

Projects

None yet

Milestone

3.10.1

Development

Successfully merging this pull request may close these issues.

3 participants

@Tyriar @pfitzseb @jerch