Skip to content

Fix npm scripts crashing when using node 10+ #1847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 24, 2018
Merged

Fix npm scripts crashing when using node 10+ #1847

merged 1 commit into from
Dec 24, 2018

Conversation

@linrock
Copy link
Contributor

@linrock linrock commented Dec 19, 2018

When using node 10+, several npm scripts crash with the following:

fs.js:25
'use strict';
^

ReferenceError: internalBinding is not defined
     at fs.js:25:1

To reproduce, try running yarn when using node 10 or 11

Updating natives to version 1.1.6 fixes this

Tyriar
Tyriar approved these changes Dec 24, 2018
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@Tyriar Tyriar added this to the 3.10.0 milestone Dec 24, 2018
@Tyriar Tyriar merged commit 272cb08 into xtermjs:master Dec 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.10.0

Development

Successfully merging this pull request may close these issues.

2 participants

@linrock @Tyriar