Fix: handle empty playlist images from API response#745
Open
danielhauser wants to merge 1 commit intoxou816:developmentfrom
Open
Fix: handle empty playlist images from API response#745danielhauser wants to merge 1 commit intoxou816:developmentfrom
danielhauser wants to merge 1 commit intoxou816:developmentfrom
Conversation
Collaborator
|
Can you test it your issue still happens in maintenance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I tried to fix the bug in #738. The problem is that the Web API may return null for images (That happens if the playlist doesn't have any songs yet for example). The behaviour is described in their API reference. I tested it locally and for me the changes do the trick. I used a default Icon as a place holder, should be fine I think.
As I am not really experienced in Rust nor in contributing to public code I would very welcome constructive feedback :)