Nest "More from artist" menu entries in submenu#531
Open
supremesnickers wants to merge 1 commit intoxou816:developmentfrom
Open
Nest "More from artist" menu entries in submenu#531supremesnickers wants to merge 1 commit intoxou816:developmentfrom
supremesnickers wants to merge 1 commit intoxou816:developmentfrom
Conversation
xou816
reviewed
Feb 18, 2023
| ); | ||
| } | ||
|
|
||
| menu.append_submenu(Some("More from"), &submenu); |
Owner
There was a problem hiding this comment.
these strings wont be translated -- you have to add a gettext call here, or I guess we could cheat and have labels::more_from_label("") here 🙈
xou816
reviewed
Feb 18, 2023
Owner
xou816
left a comment
xou816
left a comment
There was a problem hiding this comment.
looking good :) sorry for the late review!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, every listed artist had its own "More from artist" menu entry, this commit nests them in a submenu with each entry representing an artist. Songs with a single artist are not affected.
Submenu:
Entries in submenu:
