Memory leak fix #99
Merged
Memory leak fix #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A lot of missing dispose();
Contributor
Author
Do not hesitate to rename things if it doesn't please you. I tried to be compatible with 0.14.0 and lower but I gave up, spans are not fully integrated in .NetStandard and have a hard time with disposeTokens(). All tests seams to pass and personal tests too, here some screen-shots of ~6min Current 0.16.0 version : Current 0.16.0 version + changes : Theses were parsing a quite complex file with includes and heavy std includes |
Owner
|
Thanks! I'm off for the few days but will get back to this PR next week |
Owner
|
Thanks a lot, I can see that it was indeed quite some work! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of missing dispose();