Simplify TypeScript handling by using in-memory programs #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

sindresorhus wants to merge 1 commit into main from simplify-ts

Member

sindresorhus commented Oct 26, 2025

Fixes #839

sindresorhus requested a review from spence-s

October 26, 2025 07:04

xojs deleted a comment from claude bot

xojs deleted a comment from claude bot

xojs deleted a comment from claude bot

xojs deleted a comment from claude bot

sindresorhus marked this pull request as draft

October 26, 2025 07:12

sindresorhus force-pushed the simplify-ts branch from 9bec58b to 9beedd2 Compare

October 26, 2025 07:23

xojs deleted a comment from claude bot

sindresorhus force-pushed the simplify-ts branch 2 times, most recently from 8e7f90b to ec16ef7 Compare

October 26, 2025 07:54

sindresorhus marked this pull request as ready for review

October 26, 2025 07:57

xojs deleted a comment from claude bot

xojs deleted a comment from claude bot

sindresorhus force-pushed the simplify-ts branch from ec16ef7 to 54e37f5 Compare

October 26, 2025 16:23

xojs deleted a comment from claude bot


          Simplify TypeScript handling by using in-memory programs

b1acb03

Fixes #839

sindresorhus force-pushed the simplify-ts branch from 54e37f5 to b1acb03 Compare

October 26, 2025 17:00

xojs deleted a comment from claude bot

spence-s reviewed

View reviewed changes

lib/handle-ts-files.ts

    
              	try {

              		const compilerOptions = getFallbackCompilerOptions(cwd);

              		const program = ts.createProgram(files, {...compilerOptions});

              		Object.defineProperty(program, 'toJSON', {

Contributor

spence-s Oct 29, 2025

Always got stuck on the serialization errors in the past with this. This is really cool.

spence-s approved these changes

View reviewed changes

Contributor

spence-s left a comment •

edited

Loading

Looks good to me! This is awesome.

I didn't run it, but looked through it thoroughly, I think its a better approach.

It's unfortunate we still have to write the virtual files to disk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet