Skip to content

eslint-config-xo/browser is missing JSON configs #829

@sholladay

Description

@sholladay

The browser config imports, modifies, and then re-exports the first config from index.js:

https://github.com/xojs/eslint-config-xo/blob/568f75fec6ee2c000bce17d12b283ee28b277cd7/browser.js#L5

However, it does not re-export the JSON configs or the (currently disabled) CSS config from index.js:

https://github.com/xojs/eslint-config-xo/blob/568f75fec6ee2c000bce17d12b283ee28b277cd7/index.js#L822-L827

This looks like a mistake to me, unless I am misunderstanding how it is supposed to be used.

All of the secondary configs have this issue: browser, space, and space-browser

Presumably it should spread the rest of the configs in, like this:

https://github.com/sholladay/eslint-config-tidy/blob/eb5a4016d0fcda2395583f0e5e5823deb657440a/index.js#L3
https://github.com/sholladay/eslint-config-tidy/blob/eb5a4016d0fcda2395583f0e5e5823deb657440a/index.js#L150

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions