Conversation
I was thinking to also move the drivers.NewCompleter() call to |
|
At the risk of coming across like a nag, I think bumping this PR seems warranted given that the issue persists and we've seen 15 releases since the proposed fix was submitted for approval. 😶🌫 |
|
bump |
|
I just tested this patch with the latest master and it still works on my end. Asking for a re review 🤞 |
handler/handler.go
Outdated
| if err = drivers.Ping(ctx, h.u, h.db); err == nil { | ||
| if h.l.Interactive() { | ||
| h.l.SetOutput(h.outputHighlighter) | ||
| h.l.Completer(completer.NewDefaultCompleter(completer.WithConnStrings(h.connStrings()))) |
There was a problem hiding this comment.
This looks redundant. We should leave this in New, and only create the driver's completer here.
|
@remisalmon Hi, I apologize for not looking at this earlier. Could you squash the commits into a single commit and I'll rebase onto master and backport it to the |
14d1f30 to
79c6e9c
Compare
Fixes #478
The drivers NewCompleter was removed from the handler between v0.18.1 and v0.19.0.
Tested locally, I had to cleanup the dependencies for go to build.