test European HTML entities #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karfau
reviewed
Jul 3, 2020
karfau
approved these changes
Jul 3, 2020
Member
karfau
left a comment
karfau
left a comment
There was a problem hiding this comment.
Besides adding all variantions I'm aware of, I like this minimal addition to the existing test suite.
Co-authored-by: Christian Bewernitz <[email protected]>
brody4hire
changed the title
brody4hire
commented
Jul 3, 2020
Member
Author
|
Unfortunately this merge did not go right for me. I meant to merge this in a single squash commit, which is what I normally do, but it ended up making a merge commit which leaves a little bit of a mess in the git commit history. I did see a message that the head had changed, with a button to try again. After I clicked the button to try again then it did merge, in a merge commit. Argh!! |
This was referenced Mar 9, 2021
This was referenced Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The immediate purpose is to add test coverage for the entityMap entries that are affected by PR #84. This should give us some extra confidence that PR #84 really does not break anything and increase the mutation score a very little bit.
It would be nice to continue adding test coverage for more European and other international entities in
lib/entities.js, which should increase the mutation score even further, someday.P.S. The downside is that this would become one more thing to be reworked when moving from vows to something more current such as Jest.