csharp call c++ library

[waruqi]

• Before adding new features and new modules, please go to issues to submit the relevant feature description first.
• Write good commit messages and use the same coding conventions as the rest of the project.
• Please commit code to dev branch and we will merge into master branch in feature
• Ensure your edited codes with four spaces instead of TAB.

---

• 增加新特性和新模块之前，请先到issues提交相关特性说明，经过讨论评估确认后，再进行相应的代码提交，避免做无用工作。
• 编写友好可读的提交信息，并使用与工程代码相同的代码规范，代码请用4个空格字符代替tab缩进。
• 请提交代码到dev分支，如果通过，我们会在特定时间合并到master分支上。
• 为了规范化提交日志的格式，commit消息，不要用中文，请用英文描述。

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates support for C# applications to seamlessly interact with native C++ shared libraries via P/Invoke. It includes a comprehensive example project that showcases this interoperability, alongside updates to the C# build system. The key improvement in the build system is the automatic management of native library search paths, which simplifies the setup for mixed-language projects across different operating systems, thereby improving developer experience and reducing configuration overhead.

Highlights

• C# P/Invoke Support: Introduced functionality for C# applications to call native C++ shared libraries using Platform Invoke (P/Invoke).
• New Test Case: Added a new test project demonstrating C# P/Invoke with a simple C++ math library.
• Automated Library Path Configuration: Enhanced the C# build rule to automatically configure native shared library search paths (PATH, DYLD_LIBRARY_PATH, LD_LIBRARY_PATH) for P/Invoke based on the operating system.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request effectively introduces C# P/Invoke functionality, enabling C# applications to interact with native C libraries. The implementation is well-structured, covering the C# application, the native C library, and the necessary Xmake build configurations. A key improvement is the modification in xmake/rules/csharp/config.lua, which correctly identifies native shared library dependencies and dynamically adds their output directories to the appropriate runtime environment variables (PATH, DYLD_LIBRARY_PATH, LD_LIBRARY_PATH) based on the host operating system. This ensures that the C# application can successfully locate and load the native library at runtime, demonstrating a solid understanding of cross-platform P/Invoke requirements. Overall, the changes are functional and well-executed.

[gemini-code-assist]

The string literal "mathlib" is repeated across multiple DllImport attributes. Repeating such literals can lead to maintainability issues; if the native library's name changes, it would require updating multiple locations. It is a good practice to define such values as a const string in a dedicated static class for P/Invoke declarations to centralize the definition and improve code organization.

For example, you could refactor these declarations into a NativeMethods class:

internal static class NativeMethods
{
    private const string NativeLib = "mathlib";

    [DllImport(NativeLib)]
    internal static extern int add(int a, int b);

    [DllImport(NativeLib)]
    internal static extern int multiply(int a, int b);
}

This approach enhances maintainability and provides a clear separation for native interop declarations.