Update fmt to 12.1.0#131
Merged
Merged
Conversation
Member
|
Coverage report is available at: full | review summary |
1 similar comment
Member
|
Coverage report is available at: full | review summary |
m7913d
approved these changes
Jan 12, 2026
doomlaur
added a commit
that referenced
this pull request
Jan 12, 2026
To ensure C++ standard conformance in the future, this PR: - adds `-Wpedantic` for GCC, and `-pedantic-errors` if `XLNT_ALL_WARNINGS_AS_ERRORS` is set - adds `/permissive-` for MSVC 2017 and newer - note: for Clang, we already used `-Weverything`, which already sets `-Wpedantic` Depends on #131 to fix compilation under MSVC 2017 (see discussion below).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
fmtto 12.1.0.This also fixes an issue when using MSVC 2017 with
/permissive-, which breaks due to issue fmtlib/fmt#4412 and has been fixed by PR fmtlib/fmt#4413, which is available sincefmt11.2.0. We were previously using a commit from themasterbranch fromfmtbetween 11.1.2 and 11.1.3.For more details, see discussion on PR #130