fixing an issue occuring due to a change made in v0.36 #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…int sizing in main axis), this allows the textinput to honor height.
Collaborator
|
This modification will break app using RN < 0.36, right? |
Contributor
Author
|
@Crash-- I am not sure (but I guess yes), sent this pull request keeping in mind that you must be having some future releases in place to support higher versions. |
Contributor
|
We effectively cannot use the released version of this module without this change. I hope that a solution can be discovered that will also support backwards compatibility. |
Owner
|
Didn't see problems in the demo app, and the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Fix unconstraint sizing in main axis), this allows the textinput to honor height and also does not trims down charachters like 'g & p'.
for more details please refer here facebook/react-native@0a9b6be