Adjust the marking of paragraphs in chatgpt-shell-proofread-paragraph-or-region #407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is a follow-up of #352. It fixes a limit of the
mark-paragraphfunction.mark-paragraphmarks a paragraph including the previous empty line (probably to facilitate cutting and pasting paragraphs). When a paragraph marked like this is proofread, the LLM usually strips the empty line, which has to be added back. This PR strips the empty lines from the marked region to avoid this step.While preparing the PR, I have also realized that the function was not working as expected in bullet points in org mode. In LaTeX and markdown modes, using
mark-paragraphon a bullet point marks the current bullet point. Not in org mode. In org mode,mark-paragraphmarks the first real paragraph after the bullet point. To avoid this behavior, I have used the functionorg-mark-elementwhen in org mode. However, there is one side effect of using this function. If the point is on an org section heading, the whole section would be marked, not just the title. Anyway, in the current version, if the point is on an section heading, this is the following paragraph that is marked, so this is not the expected behavior anyway.