Refactor packages info to remove conflicting logging #571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Small refactoring to gate missing
flash_attnwarning logs behind not havingAITERinstalled.Why
Currently when running xDiT on AMD devices, one can use AITER instead of
flash_attn, which meansflash_attndoesn't even have to be installed.Having AITER installed, xDiT correctly logs that AITER is installed and will be used as the attention library, but missing
flash_attnthen triggers another warning log:SDPA will not be used if AITER is present, so this PR gates this warning, so only if AITER is not installed will this be logged.