feat: prefix content script names#2053
Closed
ExposedCat wants to merge 1 commit intowxt-dev:mainfrom
Closed
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
|
Thanks for taking the time to create a PR, but I don't want to change the entrypoint patterns right now. See #2043 (comment) for more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Currently, only
unique-name.contentcan be used for naming content scripts. This results in inconvenient sorting in IDEs, such as:This PR allows to use
content.unique-nameformat, so we would havewhich essentially groups content scripts in places such as IDE file viewers
Manual Testing
Create any content script at
entrypoints/content.name/index.tsorentrypoints/content.name.tsRelated Issue
N/A
This PR closes #2043